Conversation
zmb3
approved these changes
Sep 14, 2023
rudream
approved these changes
Sep 14, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
avatus
added a commit
that referenced
this pull request
Sep 15, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 16, 2023
* Ad a storybook for the Unified Resources screen (#31213) * Add a mock service worker Storybook add-on * Add a Resources story * Add the license * Lint fix * Scroll up when collapsing labels (#31755) This is an UX improvement to keep the user focused on the card they're viewing when they scroll down a large list of labels. * Only show copy button on hover (#31920) --------- Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the "Copy" name button on unified resource cards only show when the card is hovered. Currently its always there on the cards. this will reduce visual clutter
a9cfe5c9f89acb1daa182385226f8295.mp4