Skip to content

pgbk: add change_feed_conn_string option#31918

Merged
espadolini merged 2 commits intomasterfrom
espadolini/pgbk-change-feed-connstring
Sep 15, 2023
Merged

pgbk: add change_feed_conn_string option#31918
espadolini merged 2 commits intomasterfrom
espadolini/pgbk-change-feed-connstring

Conversation

@espadolini
Copy link
Copy Markdown
Contributor

@espadolini espadolini commented Sep 14, 2023

This PR adds a new change_feed_conn_string option to the pgbk options, allowing the use of a different user for the change feed connection. This can be useful if only a specific user has permissions to do replication.

This PR also includes minor polishing that doesn't warrant a dedicated PR.

Copy link
Copy Markdown
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from bl-nero September 15, 2023 09:31
@espadolini espadolini added this pull request to the merge queue Sep 15, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2023
@espadolini espadolini added this pull request to the merge queue Sep 15, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2023
@espadolini espadolini added this pull request to the merge queue Sep 15, 2023
Merged via the queue into master with commit 83d4007 Sep 15, 2023
@espadolini espadolini deleted the espadolini/pgbk-change-feed-connstring branch September 15, 2023 11:55
@public-teleport-github-review-bot
Copy link
Copy Markdown

@espadolini See the table below for backport results.

Branch Result
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants