Fix directory sharing for non-ascii directory names#31899
Merged
ibeckermayer merged 4 commits intomasterfrom Sep 15, 2023
Merged
Fix directory sharing for non-ascii directory names#31899ibeckermayer merged 4 commits intomasterfrom
ibeckermayer merged 4 commits intomasterfrom
Conversation
Previously we were sending the shared directory's name for PreferredDosName (truncated at 7 characters per the spec). This works in many cases, but if the directory name contains non-ASCII characters it could lead to a panic when we tried to slice the name in the middle of a non-ascii UTF character. Instead, we now send a fixed string of "FILE" for PreferredDosName when sharing a filesystem (directory). This value is effectively ignored, the actual drive name is always taken from the DeviceData field which can handle non-ASCII characters.
zmb3
approved these changes
Sep 14, 2023
zmb3
approved these changes
Sep 14, 2023
rosstimothy
approved these changes
Sep 14, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from AntonAM
|
@ibeckermayer See the table below for backport results.
|
This was referenced Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were sending the shared directory's name for PreferredDosName (truncated at 7 characters per the spec). This works in many cases, but if the directory name contains non-ASCII characters it could lead to a panic when we tried to slice the name in the middle of a non-ascii UTF character.
Instead, we now send a fixed string of "FILE" for PreferredDosName when sharing a filesystem (directory). This value is effectively ignored, the actual drive name is always taken from the DeviceData field which can handle non-ASCII characters.