Implement semantic search API for unified resources#31881
Merged
Conversation
xacrimon
force-pushed
the
joel/smart-search-scrap
branch
from
2210aa1 to
ddcf2f6
Compare
xacrimon
force-pushed
the
joel/smart-search-scrap
branch
2 times, most recently
from
521d88d to
8238b3c
Compare
Contributor
Author
|
Huh, this is odd. If I reset the go.mod to be equiv to master I keep getting weird failures and go.mod tidy wants to revert versions? |
Contributor
Author
|
Above should be fixed now. Still trying to repro and fix the flaky test locally but can't get the same failure to occur. |
jakule
suggested changes
Sep 21, 2023
Contributor
jakule
left a comment
jakule
left a comment
There was a problem hiding this comment.
Above should be fixed now. Still trying to repro and fix the flaky test locally but can't get the same failure to occur.
The flaky test detector is taming out because this test takes 10 seconds to execute.
xacrimon
force-pushed
the
joel/smart-search-scrap
branch
from
25b1b44 to
50948fe
Compare
avatus
approved these changes
Sep 28, 2023
Contributor
|
Doesn't relate directly to this PR, but I'm proposing some changes to the unified resource cache here that might be useful to your interactions with it |
Contributor
Author
|
Thanks for the heads up @avatus ! |
jakule
approved these changes
Oct 2, 2023
Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
xacrimon
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Implement semantic search API for unified resources * use require.eventually to complete test faster * reset mod and sum * Update lib/auth/assist/assistv1/test/service_test.go Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * use correct proto numbering * reset e * make grpc --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new API on the Assist gRPC service called
SearchUnifiedResources. This API is gated behind assist being enabled together with all other Assist APIs and is off unless Assist is otherwise enabled || you're on Cloud Team plan.This API searches the unified resource cache already present on the Auth server and returns resources of one or more kinds that the user has access to, ordered by semantic closeness. Otherwise it behaves very similar to existing resource fetch APIs. Since the kind of resource the user wants is not always obvious, this API is multi-kind i.e it supports returning resources of more than one kind and we can piggyback off embedding distance to guess the most reasonable resource kind.