Skip to content

[v14] Web: Add new supported aws region (il-central-1) to selector#31839

Merged
kimlisa merged 2 commits intobranch/v14from
bot/backport-31825-branch/v14
Sep 14, 2023
Merged

[v14] Web: Add new supported aws region (il-central-1) to selector#31839
kimlisa merged 2 commits intobranch/v14from
bot/backport-31825-branch/v14

Conversation

@kimlisa
Copy link
Copy Markdown
Contributor

@kimlisa kimlisa commented Sep 13, 2023

Backport #31825 to branch/v14

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Sep 14, 2023

I thought discovery still doesn't support this region in older branches? @greedy52

@marcoandredinis
Copy link
Copy Markdown
Contributor

I thought discovery still doesn't support this region in older branches? @greedy52

This is not used by the discovery_service
It will only fetch a single database information and add it as a Database to teleport (the same as adding the info to the db_service or using a tctl create <database>.yaml)

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from greedy52 September 14, 2023 07:03
@kimlisa kimlisa added this pull request to the merge queue Sep 14, 2023
@marcoandredinis marcoandredinis removed this pull request from the merge queue due to a manual request Sep 14, 2023
@marcoandredinis
Copy link
Copy Markdown
Contributor

@kimlisa Sorry for removing the auto-merge, let's clarify Zac's question first

@greedy52
Copy link
Copy Markdown
Contributor

greedy52 commented Sep 14, 2023

I thought discovery still doesn't support this region in older branches? @greedy52

AWS SDK in general works with "unknown" regions so this should be fine.

(For context), an error was thrown if an unknown region was found when parsing the discovery service's static config. I've changed this behaviour to do a regex validation instead of testing against a list of known regions. That change will be backported today as well.

@kimlisa kimlisa enabled auto-merge September 14, 2023 18:32
@kimlisa kimlisa added this pull request to the merge queue Sep 14, 2023
Merged via the queue into branch/v14 with commit 324e592 Sep 14, 2023
@kimlisa kimlisa deleted the bot/backport-31825-branch/v14 branch September 14, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants