[v14] make tsh match against discovered db name#31838
Merged
GavinFrazar merged 1 commit intobranch/v14from Sep 14, 2023
Merged
Conversation
* disallow prefix matching * select by exact name match first, * otherwise look for unambiguous discovered name label match. * look for an active db to resolve discovered name match ambiguity. * add more predicate builder helpers * check for db name in not found error for stale cert hint * no error status on tsh db logout with no logged in dbs * remove dead code * refactor helper funcs to simplify code and make it easier to test * test complex database selection * test findActiveDatabase * test choosing one db by discovered name * add more resource selectors tests * test formatDatabaseLoginCommand * add debug logging for db selection
github-actions
Bot
added
backport
size/md
tsh
smallinsky
approved these changes
Sep 14, 2023
greedy52
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #31689 to branch/v14