Prevent trusted clusters in Cloud#31815
Merged
rosstimothy merged 1 commit intomasterfrom Sep 13, 2023
Merged
Conversation
dboslee
reviewed
Sep 13, 2023
zmb3
approved these changes
Sep 13, 2023
codingllama
reviewed
Sep 13, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Do you think it's worth adding a test for it?
codingllama
reviewed
Sep 13, 2023
codingllama
approved these changes
Sep 13, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from lxea
rosstimothy
force-pushed
the
tross/cloud_tc
branch
from
d2f3f74 to
233322a
Compare
|
@rosstimothy See the table below for backport results.
|
This was referenced Sep 14, 2023
rosstimothy
added a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
rosstimothy
added a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
#31815 already prevented a Cloud tenant from being a root cluster but it did not stop a Cloud tenant from being a leaf. This prevents the creating of `trusted_cluster` resources which effectively blocks any attempts to make Cloud be a leaf cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.