Conversation
Desktops cannot contain '.' characters in their names, as we use SNI
to pass the desktop name in the TLS handshake. This wasn't a problem
in the past when Teleport was the only thing that created desktops,
as we were sure to sanitize names. With non-AD access we encourage
users to register their own desktops via API or tctl, and they often
encounter a confusing TLS error when they use an invalid name.
With this change:
➜ tctl create -f desktop-resource.yaml
ERROR: invalid name "this-is-a.test": desktop names cannot contain periods
Fixes #31644
tigrato
approved these changes
Sep 12, 2023
ibeckermayer
approved these changes
Sep 12, 2023
Contributor
ibeckermayer
left a comment
ibeckermayer
left a comment
There was a problem hiding this comment.
It seems like we don't have any examples of manually adding a windows desktop in the docs, is that something we want to add?
public-teleport-github-review-bot
Bot
removed the request for review
from camscale
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
We do: teleport/docs/pages/desktop-access/getting-started.mdx Lines 116 to 120 in 766436a |
This was referenced Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktops cannot contain '.' characters in their names, as we use SNI to pass the desktop name in the TLS handshake. This wasn't a problem in the past when Teleport was the only thing that created desktops, as we were sure to sanitize names. With non-AD access we encourage users to register their own desktops via API or tctl, and they often encounter a confusing TLS error when they use an invalid name.
With this change:
Fixes #31644