[v12] Kubernetes External Joining: static_jwks implementation (#30225)#31704
Merged
strideynet merged 3 commits intobranch/v12from Sep 12, 2023
Merged
[v12] Kubernetes External Joining: static_jwks implementation (#30225)#31704strideynet merged 3 commits intobranch/v12from
static_jwks implementation (#30225)#31704strideynet merged 3 commits intobranch/v12from
Conversation
* Add JWKS baseed kubernetes toekn validator * Add types for static_jwks kubernetes join type * Add validation for new fields on Provisiontoken * SPAG * Add support into tbot for kubernetes join method * Wire static_jwks implementation into auth.Server.checkKubernetesJoinRequest * fix-imports * Add JWKS tests for `kubernetestoken` * Fix TestIDTokenValidator_Validate * Ensure token is bound * Fix mistakenely renamed comments * Tidier return type * Refactor tests for slicker UI * Inject jwks token validator for test substitution * Add test cases for static_jwks to lib/auth kube joining test * Remove TODO * Add more test cases to token validation * Add enforcement of maximum TTL * Regenerate operator crd * Improve comments on proto * Rerun ?? generation ?? of ?? operator ?? protos ?? * Remove outdated comment
hugoShaka
approved these changes
Sep 11, 2023
tigrato
approved these changes
Sep 11, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from r0mant
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #30225