Merged
Conversation
ibeckermayer
approved these changes
Sep 7, 2023
kimlisa
approved these changes
Sep 7, 2023
Contributor
There was a problem hiding this comment.
can we add explanation here? because i found it pretty strange too
avatus
force-pushed
the
avatus/fix_login_options
branch
from
881ee49 to
62b4377
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31592
Took me a bit to debug why this was happening. Apparently,
autocompleteis ignored by almost every browser now. The only reason this showed up in safari specifically is, our input wasn't named or typed like "password" so the browsers think "cool, just an input". but safari actually also checks the PLACEHOLDER text, and since our placeholder text included the word "login", it would ignore the autocomplete and add the widget. You can test this out yourself by changing the placeholder text in this input field with something like "hi". Blew my mind.The added name prop and value are what safari prescribes to ignore autofill.
Some info here with the answer found below the accepted answer (although its all good info)