Merged
Conversation
zmb3
reviewed
Sep 7, 2023
Collaborator
There was a problem hiding this comment.
Should we check the type assertion just so this doesn't panic if another bug slips through in the future?
Also, I don't suggest changing thiw now, but we probably don't need UnmarshalTerminalParams at all - the frontend is sending
{
"event": "resize",
"width": 105,
"height": 53,
"size": "105:53"
}
We're taking "105:53" and parsing it to integers 105 and 53. This isn't really necessary since the UI already sent us those values as numbers. 🤷♂️
rudream
force-pushed
the
yassine/fix-terminal-resizing
branch
from
9612728 to
fed739c
Compare
zmb3
reviewed
Sep 7, 2023
rosstimothy
approved these changes
Sep 7, 2023
zmb3
approved these changes
Sep 7, 2023
public-teleport-github-review-bot
Bot
removed request for
EdwardDowling and
avatus
rudream
force-pushed
the
yassine/fix-terminal-resizing
branch
from
b46dfea to
94d2fd6
Compare
This was referenced Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR resolves #31565
Fixes resizing not working properly in the web terminal. This was caused because we were trying to unmarshal the payload which contains number values into a
map[string]string.Demo
Before
Screen.Recording.2023-09-07.at.10.46.07.AM.mov
After
Screen.Recording.2023-09-07.at.10.50.13.AM.mov