Merged
Conversation
We request only IPv4 addresses when doing DNS queries for Windows
desktops. In some circumstances, we can get addresses that are
represented ("mapped") as IPv6 addresses. Unmap them so that Teleport
always stores the IPv4 format.
espadolini
approved these changes
Aug 30, 2023
| result := make([]netip.Addr, 0, len(addrs)) | ||
| for _, addr := range addrs { | ||
| if addr.Is4() || addr.Is4In6() { | ||
| result = append(result, addr.Unmap()) |
Contributor
There was a problem hiding this comment.
Are we worried about actual ipv6 addresses being returned here? We could just do addrs[i] = addrs[i].Unmap() if that's not the case, Unmap is a noop for ipv4 addresses.
Collaborator
Author
There was a problem hiding this comment.
I wasn't worried about them showing up before and then we ran in to this bug, so I'd rather be extra defensive.
rosstimothy
approved these changes
Aug 31, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
tcsc
This was referenced Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We request only IPv4 addresses when doing DNS queries for Windows desktops. In some circumstances, we can get addresses that are represented ("mapped") as IPv6 addresses. Unmap them so that Teleport always stores the IPv4 format.