[v14] Remove use of require assertions inside Eventually calls#31226
Merged
zmb3 merged 2 commits intobranch/v14from Aug 31, 2023
Merged
[v14] Remove use of require assertions inside Eventually calls#31226zmb3 merged 2 commits intobranch/v14from
zmb3 merged 2 commits intobranch/v14from
Conversation
require.Eventually runs the predicate function in a background goroutine. It is invalid to use require to make assertions inside the eventually, because require will fail the test if the assertion fails, and tests can only be failed from the test's main goroutine.
github-actions
Bot
requested review from
hugoShaka,
rosstimothy and
strideynet
github-actions
Bot
added
backport
database-access
rosstimothy
approved these changes
Aug 30, 2023
tigrato
approved these changes
Aug 30, 2023
public-teleport-github-review-bot
Bot
removed request for
hugoShaka and
strideynet
strideynet
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #31112 to branch/v14