Use the Go 1.21.0 toolchain to build modules#31171
Closed
codingllama wants to merge 2 commits intomasterfrom
Closed
Use the Go 1.21.0 toolchain to build modules#31171codingllama wants to merge 2 commits intomasterfrom
codingllama wants to merge 2 commits intomasterfrom
Conversation
Joerger
approved these changes
Aug 29, 2023
97654d3 to
3991c36
Compare
Contributor
Author
|
Dropped "Build CI Buildbox Images" changes in favor of #31173. |
3991c36 to
e1ac31b
Compare
Contributor
Author
|
Also dropped api/go.mod toolchain line, as it won't build directly with Go 1.19 because of that. We could keep the toolchain line and it should still be go-gettable, or at least that's what I'm led to believe, but then we'd have to change the "Build API Module" action to use Go 1.21+. $ cd "$(mktemp -d)"
$ go1.19.12 mod init test
> go: creating new go.mod: module test
$ go1.19.12 get github.com/gravitational/teleport/api@3991c36
> go: added cloud.google.com/go/compute v1.20.1
> go: added cloud.google.com/go/compute/metadata v0.2.3
> go: added github.com/gravitational/teleport/api v0.0.0-20230829195104-3991c368e931
$ cat go.mod
> module test
>
> go 1.19
>
> require (
> cloud.google.com/go/compute v1.20.1 // indirect
> cloud.google.com/go/compute/metadata v0.2.3 // indirect
> github.com/gravitational/teleport/api v0.0.0-20230829195104-3991c368e931 // indirect
> ) |
370cc1b to
b49cddd
Compare
jakule
reviewed
Aug 29, 2023
Contributor
jakule
left a comment
There was a problem hiding this comment.
CI is not happy
/__w/teleport/teleport/go.mod:5: unknown directive: toolchain
Contributor
Author
|
CI was running a pre-Go 1.21 image, see #31173. I didn't manually re-run all the failed jobs, but judging from Unit Tests I think we are good now. |
jakule
approved these changes
Aug 30, 2023
Contributor
jakule
left a comment
There was a problem hiding this comment.
If CI gods are happy, I'm not going to disagree with them.
Contributor
Author
|
This is obsolete since #31231. |
This was referenced Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has (mostly) no practical effect as of right now, but it's a convenient way to bump the Go version for future patches/releases.
Done using
go get toolchain@go1.21.