[buddy] Add an optional PodMonitor to the teleport-kube-agent chart#31169
Merged
[buddy] Add an optional PodMonitor to the teleport-kube-agent chart#31169
Conversation
github-actions
Bot
requested review from
lsgunn-teleport,
ptgott,
xinding33 and
zmb3
strideynet
approved these changes
Aug 30, 2023
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Looks good but docs could be clearer
|
|
||
| `podMonitor` controls [the PodMonitor CR (from monitoring.coreos.com/v1) | ||
| ](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#monitoring.coreos.com/v1.PodMonitor) | ||
| This custom resource is used to configure Prometheus to monitor workload running |
Contributor
There was a problem hiding this comment.
I think we can improve this help text - at no point does it really say that it'll enable monitoring of the workloads deployed by this chart 😅
zmb3
approved these changes
Aug 30, 2023
public-teleport-github-review-bot
Bot
removed request for
lsgunn-teleport,
marcoandredinis,
ptgott,
r0mant and
tigrato
tigrato
approved these changes
Aug 30, 2023
hugoShaka
commented
Aug 30, 2023
hugoShaka
commented
Aug 30, 2023
|
@hugoShaka See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30944
Buddy PR for #30945
This PR also adds a documentation commit adding the field to the chart reference (it was also missing from
teleport-cluster).