Skip to content

Add known STS endpoint for il-central-1#31166

Merged
greedy52 merged 3 commits intomasterfrom
STeve/il_central_1
Aug 31, 2023
Merged

Add known STS endpoint for il-central-1#31166
greedy52 merged 3 commits intomasterfrom
STeve/il_central_1

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

Comes from support shift where a customer enables the new region.

Using github.com/aws/aws-sdk-go v1.44.333 for github.com/nklaassen/sts-endpoints

However, for the long term, we should consider generating the STS endpoints from the SDK by code, instead of hard-coding in a slice.

@greedy52 greedy52 added support-load This issue generates support load backport/branch/v12 labels Aug 29, 2023
@greedy52 greedy52 requested review from nklaassen and tigrato August 29, 2023 17:57
@greedy52 greedy52 self-assigned this Aug 29, 2023
@github-actions github-actions Bot requested review from hugoShaka and rudream August 29, 2023 17:58
@tigrato
Copy link
Copy Markdown
Contributor

tigrato commented Aug 29, 2023

Can we replace the generator with SDK based data or adding a ci step that prevents the drift even for older versions

@reedloden
Copy link
Copy Markdown
Contributor

Can we replace the generator with SDK based data or adding a ci step that prevents the drift even for older versions

https://docs.aws.amazon.com/sdk-for-go/api/aws/endpoints/ (v1 only)

@greedy52
Copy link
Copy Markdown
Contributor Author

greedy52 commented Aug 30, 2023

Can we replace the generator with SDK based data or adding a ci step that prevents the drift even for older versions

https://docs.aws.amazon.com/sdk-for-go/api/aws/endpoints/ (v1 only)

Yes, we do something similar here:

// awsRegions returns the list of all regions available on every aws partition.
// It is used to validate the AWSMatcher.Regions values.
func awsRegions() []string {
var regions []string
partitions := endpoints.DefaultPartitions()
for _, partition := range partitions {
regions = append(regions, maps.Keys(partition.Regions())...)
}
return regions
}

And in Nic's separate repo https://github.com/nklaassen/sts-endpoints

Can we replace the generator with SDK based data or adding a ci step that prevents the drift even for older versions

Let me do that in a separate PR as an alternative.

@greedy52 greedy52 enabled auto-merge August 30, 2023 20:22
@greedy52 greedy52 added this pull request to the merge queue Aug 31, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 31, 2023
@greedy52 greedy52 added this pull request to the merge queue Aug 31, 2023
Merged via the queue into master with commit 493532e Aug 31, 2023
@greedy52 greedy52 deleted the STeve/il_central_1 branch August 31, 2023 15:08
@public-teleport-github-review-bot
Copy link
Copy Markdown

@greedy52 See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sm support-load This issue generates support load

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants