[v13] Respect [HTTP(S)|NO]_PROXY envs when dialing directly to Kube via SPDY#31133
Merged
tigrato merged 1 commit intobranch/v13from Aug 29, 2023
Merged
[v13] Respect [HTTP(S)|NO]_PROXY envs when dialing directly to Kube via SPDY#31133tigrato merged 1 commit intobranch/v13from
[HTTP(S)|NO]_PROXY envs when dialing directly to Kube via SPDY#31133tigrato merged 1 commit intobranch/v13from
Conversation
…PDY (#30624) * Respect `[HTTP(S)|NO]_PROXY` envs when dialing directly to Kube via SPDY This PR enables support for proxy env's when dialing directly to the Kubernetes Cluster - `kubernetes_service` and `legacy_proxy` when the cluster is local - for the SPDY protocol used by `kubectl exec` and `kubectl portforward`. PR #30583 introduced support for normal HTTP requests but missed support for SPDY requests. Fixes #30550 Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * add proxier helper --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
espadolini
approved these changes
Aug 29, 2023
greedy52
approved these changes
Aug 29, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from Joerger
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #30624 to branch/v13