Don't set additional groups on darwin#31132
Merged
espadolini merged 2 commits intomasterfrom Aug 29, 2023
Merged
Conversation
tigrato
approved these changes
Aug 29, 2023
Tener
approved these changes
Aug 29, 2023
jakule
approved these changes
Aug 29, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@espadolini See the table below for backport results.
|
This was referenced Aug 29, 2023
Collaborator
|
Did this make it into v14? |
Contributor
Author
|
Yeah, the backport "failed" because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so that we don't set the list of additional groups when spawning processes as a user other than the one running the
teleportbinary on macOS; setting the list to more than 16 groups is not possible, and the call to setgroups is "highly discouraged" (as per the man page in macOS 13.5), and the system seems to pick up the correct list of additional groups just fine even without our effort.Fixes #3167.