Conversation
This is a 3rd-party action with access to some moderately privileged GitHub Applications private tokens. If tibdex were compromised for any reason, we don't want to accidentally pick up an unexpected malicious update to v1.
zmb3
reviewed
Aug 28, 2023
zmb3
approved these changes
Aug 28, 2023
adaadb6
approved these changes
Aug 28, 2023
Contributor
adaadb6
left a comment
adaadb6
left a comment
There was a problem hiding this comment.
LGTM! Corresponding issue: https://github.com/gravitational/SecOps/issues/403
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 3rd-party action with access to some moderately privileged GitHub Applications private tokens. If the
tibdexuser were compromised for any reason, we don't want to pick up an unexpected malicious update to v1.I have a followup dependabot config, to ensure this stays current in a controlled fashion:
#31119
Also, we may move to github's in house https://github.com/actions/create-github-app-token once it is more mature -- but it is only a couple weeks old right now.
Corresponding Enterprise PR: https://github.com/gravitational/teleport.e/pull/2070