Add the ability to run a specific tool to Assist.#31113
Merged
Conversation
jakule
approved these changes
Aug 30, 2023
xacrimon
approved these changes
Aug 31, 2023
hugoShaka
force-pushed
the
hugo/assist-invoke-audit-query
branch
from
5facde1 to
4222fc8
Compare
public-teleport-github-review-bot
Bot
removed the request for review
from zmb3
This commit contains: - a refactoring of the model action logic to be exposed through the `DoAction` function - Expose `RunTool()` capability through ai.Client and assist.Assist - Add the "audit-query" action that invokes directly the audit generation tool
hugoShaka
force-pushed
the
hugo/assist-invoke-audit-query
branch
from
91e9bbd to
efebdea
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
DoActionfunctionRunTool()capability exposed by ai.Client and assist.AssistThe DoAction/RunTool invocation method, as opposed to regular Chat invocation, is motivated by response time. On a chat invocation, it takes 6 seconds to start streaming the tool response. Of those 6 seconds, 5 are spent on the action planning and 1 on the actual tool. In cases where we know which tool we want to use, invoking the tool directly removes those 5 extra seconds and dramatically improves the UX.