skip motd in UI if request initiated from tsh headless auth#31050
Merged
flyinghermit merged 5 commits intomasterfrom Aug 29, 2023
Merged
skip motd in UI if request initiated from tsh headless auth#31050flyinghermit merged 5 commits intomasterfrom
flyinghermit merged 5 commits intomasterfrom
Conversation
Contributor
Author
|
FYI @zmb3, I have manually tested this and it seems to do the trick. Tested with both local user account and for user connected with Github auth. LMK if there's other scenario I may have missed. |
zmb3
reviewed
Aug 26, 2023
gzdunek
reviewed
Aug 28, 2023
- rename redirect_uri to redirectUri - add explicit default showMotd type and setShowMotd return type
gzdunek
reviewed
Aug 29, 2023
zmb3
approved these changes
Aug 29, 2023
gzdunek
approved these changes
Aug 29, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from kimlisa
This was referenced Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When login in Web UI is initiated for headless auth, for example with authentication link generated by
tsh --headlesscommand:opening the link in browser redirects to login page with the following redirect format:
https://<proxy>/web/login?redirect_uri=https://<proxy>/web/headless/c7bd5f24-d487-5dd4-b30e-371a80bd5993To disable MOTD when auth is initiated from headless auth, now we set
showMotd = falseif login url includesredirect_uriand theredirect_uriincludesheadless.Tested with both local user and Github user configured with Github auth.
closes #28746