Add initial servicenow plugin#31024
Merged
EdwardDowling merged 35 commits intomasterfrom Sep 11, 2023
Merged
Conversation
EdwardDowling
force-pushed
the
edwarddowling/service-now-plugin
branch
from
5601013 to
77c8143
Compare
tigrato
reviewed
Aug 29, 2023
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
I saw your loom recording for this new feature 👏
Would you mind adding some tests
tigrato
reviewed
Sep 5, 2023
|
@EdwardDowling - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
tigrato
approved these changes
Sep 8, 2023
Contributor
tigrato
left a comment
tigrato
left a comment
There was a problem hiding this comment.
Please document where the labels are coming from, otherwise LGTM
EdwardDowling
force-pushed
the
edwarddowling/service-now-plugin
branch
from
6b40791 to
7760f04
Compare
marcoandredinis
approved these changes
Sep 8, 2023
r0mant
requested changes
Sep 8, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
Requesting changes for now until we clarify what these "close code" annotations are for.
Contributor
Author
Added in those changes we discussed on slack to this and the /e PR. |
r0mant
approved these changes
Sep 11, 2023
And fix capitalisation in some error messages.
EdwardDowling
force-pushed
the
edwarddowling/service-now-plugin
branch
from
4fc0130 to
1f4b589
Compare
|
@EdwardDowling See the table below for backport results.
|
EdwardDowling
added a commit
that referenced
this pull request
Sep 19, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Add initial servicenow plugin (#31024) * Use createAccessrequestV2 for servicenow tests --------- Co-authored-by: Roman Tkachenko <roman@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the changes for #15366