Skip to content

Periodically refresh Azure cloud credentials#31004

Merged
atburke merged 1 commit intomasterfrom
atburke/azure-client-refresh
Aug 29, 2023
Merged

Periodically refresh Azure cloud credentials#31004
atburke merged 1 commit intomasterfrom
atburke/azure-client-refresh

Conversation

@atburke
Copy link
Copy Markdown
Contributor

@atburke atburke commented Aug 24, 2023

This PR lets Teleport periodically refresh Azure cloud credentials, allowing Teleport to get updated credentials without a restart.

Resolves #28880.

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Aug 25, 2023

@fspmarshall do you think FnCache would be a better option than TTLMap here?

@fspmarshall
Copy link
Copy Markdown
Contributor

I'd definitely check out utils.FnCache for this usecase. It's used heavily throughout the codebase and does better under concurrency.

This change lets Teleport periodically refresh Azure cloud credentials,
allowing Teleport to get updated credentials without a restart.
@atburke atburke force-pushed the atburke/azure-client-refresh branch from 6bea5c8 to 066cd0f Compare August 28, 2023 23:41
@atburke atburke enabled auto-merge August 28, 2023 23:42
@atburke atburke added this pull request to the merge queue Aug 28, 2023
Merged via the queue into master with commit ebf69b6 Aug 29, 2023
@atburke atburke deleted the atburke/azure-client-refresh branch August 29, 2023 00:16
@public-teleport-github-review-bot
Copy link
Copy Markdown

@atburke See the table below for backport results.

Branch Result
branch/v13 Create PR
branch/v14 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure VM auto-discovery is unable to refresh credentials

5 participants