Skip to content

Fix flaky TestResizeTerminal#30970

Merged
zmb3 merged 1 commit intomasterfrom
zmb3/fix-resize-test
Aug 24, 2023
Merged

Fix flaky TestResizeTerminal#30970
zmb3 merged 1 commit intomasterfrom
zmb3/fix-resize-test

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Aug 24, 2023

This test starts a session and then immediately tries to join it. Sometimes we're too fast, and the session tracker doesn't yet exist so the join fails.

Fix by waiting for the session tracker to show up before attempting the join.

Closes #13607

This test starts a session and then immediately tries to join it.
Sometimes we're too fast, and the session tracker doesn't yet exist
so the join fails.

Fix by waiting for the session tracker to show up before attempting
the join.

Closes #13607
@zmb3 zmb3 added this pull request to the merge queue Aug 24, 2023
Merged via the queue into master with commit 380c284 Aug 24, 2023
@zmb3 zmb3 deleted the zmb3/fix-resize-test branch August 24, 2023 17:13
@public-teleport-github-review-bot
Copy link
Copy Markdown

@zmb3 See the table below for backport results.

Branch Result
branch/v11 Create PR
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestResizeTerminal flakiness

3 participants