Improve proxy address sourcing for VM auto-discovery#30884
Merged
Conversation
codingllama
reviewed
Aug 23, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Overall looks good.
Add backport labels?
codingllama
reviewed
Aug 23, 2023
codingllama
approved these changes
Aug 23, 2023
gabrielcorado
approved these changes
Aug 24, 2023
This change adds a few more places for the Discovery service to get the Teleport cluster's public proxy address for VM discovery.
atburke
force-pushed
the
atburke/vm-discovery-proxy-addr
branch
from
5c1c10e to
6d78066
Compare
atburke
added a commit
that referenced
this pull request
Aug 24, 2023
This change adds a few more places for the Discovery service to get the Teleport cluster's public proxy address for VM discovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few more places for the Discovery service to get the Teleport cluster's public proxy address for VM discovery.
Fixes #28838.