Skip to content

AWS OIDC: Configure IAM for EC2 Instance Connect Endpoint#30851

Merged
marcoandredinis merged 3 commits intomasterfrom
marco/oneoff_configure_eice_iam
Aug 24, 2023
Merged

AWS OIDC: Configure IAM for EC2 Instance Connect Endpoint#30851
marcoandredinis merged 3 commits intomasterfrom
marco/oneoff_configure_eice_iam

Conversation

@marcoandredinis
Copy link
Copy Markdown
Contributor

@marcoandredinis marcoandredinis commented Aug 22, 2023

Context: #29317
This PR adds a new teleport command that sets up the required permissions to use EC2 Instance Connect Endpoint to connect to an EC2 instance.

It also adds a oneoff script that runs this command. The goal is to give a user a script for them to run, the script then downloads teleport and calls AWS APIs to create the inline policy.

Demo
image

(semi fake demo because I couldn't came up with a dev build)

@marcoandredinis marcoandredinis added discover Issues related to Teleport Discover backport/branch/v13 labels Aug 22, 2023
@marcoandredinis marcoandredinis force-pushed the marco/oneoff_configure_eice_iam branch from 15a031d to e2e3ed3 Compare August 22, 2023 16:13
@marcoandredinis marcoandredinis marked this pull request as ready for review August 22, 2023 16:18
@github-actions github-actions Bot requested review from avatus and mdwn August 22, 2023 16:19
@marcoandredinis marcoandredinis marked this pull request as draft August 22, 2023 16:38
@marcoandredinis marcoandredinis force-pushed the marco/oneoff_configure_eice_iam branch from e2e3ed3 to e638cf8 Compare August 22, 2023 17:49
@marcoandredinis marcoandredinis marked this pull request as ready for review August 22, 2023 17:50
@marcoandredinis marcoandredinis force-pushed the marco/oneoff_configure_eice_iam branch 2 times, most recently from 65d33c5 to 744c563 Compare August 23, 2023 14:15
Copy link
Copy Markdown
Contributor

@smallinsky smallinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but the code LGTM.

Comment thread lib/integrations/awsoidc/eice_iam_config.go Outdated
Comment thread lib/integrations/awsoidc/eice_iam_config.go Outdated
This PR adds a new teleport command that sets up the required
permissions to use EC2 Instance Connect Endpoint to connect to an EC2
instance.

It also adds a oneoff script that runs this command.
The goal is to give a user a script for them to run, the script then
downloads teleport and calls AWS APIs to create the inline policy.
@marcoandredinis marcoandredinis force-pushed the marco/oneoff_configure_eice_iam branch 3 times, most recently from d98a2b3 to 4158f66 Compare August 24, 2023 09:55
@marcoandredinis marcoandredinis force-pushed the marco/oneoff_configure_eice_iam branch from 4158f66 to 2add505 Compare August 24, 2023 10:48
@marcoandredinis marcoandredinis added this pull request to the merge queue Aug 24, 2023
Merged via the queue into master with commit 33185f9 Aug 24, 2023
@marcoandredinis marcoandredinis deleted the marco/oneoff_configure_eice_iam branch August 24, 2023 11:50
@public-teleport-github-review-bot
Copy link
Copy Markdown

@marcoandredinis See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discover Issues related to Teleport Discover size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants