Skip to content

[v13] [buddy] 🐛 issue #30400 fixing missing billing_mode param in teleport-cluster helm chart fo dynamodb autoscaling #30841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugoShaka merged 2 commits into from
Aug 22, 2023
Merged

[v13] [buddy] 🐛 issue #30400 fixing missing billing_mode param in teleport-cluster helm chart fo dynamodb autoscaling #30841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f283ffb
:bug: issue #30400, dynamodb autoscaling mode requires `billing_mode:…
anaye1997 Aug 13, 2023
32d5f24
Add tests
hugoShaka Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/chart/teleport-cluster/templates/auth/_config.aws.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
continuous_backups: {{ required "aws.backups is required in chart values" .Values.aws.backups }}
{{- if .Values.aws.dynamoAutoScaling }}
auto_scaling: true
billing_mode: provisioned
read_min_capacity: {{ required "aws.readMinCapacity is required when aws.dynamoAutoScaling is true" .Values.aws.readMinCapacity }}
read_max_capacity: {{ required "aws.readMaxCapacity is required when aws.dynamoAutoScaling is true" .Values.aws.readMaxCapacity }}
read_target_value: {{ required "aws.readTargetValue is required when aws.dynamoAutoScaling is true" .Values.aws.readTargetValue }}
Expand Down
1 change: 1 addition & 0 deletions examples/chart/teleport-cluster/tests/__snapshot__/auth_config_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ matches snapshot for aws-dynamodb-autoscaling.yaml:
- dynamodb://test-dynamodb-auditlog-table
audit_sessions_uri: s3://test-s3-session-storage-bucket
auto_scaling: true
billing_mode: provisioned
continuous_backups: false
read_max_capacity: 100
read_min_capacity: 5
Expand Down
8 changes: 8 additions & 0 deletions examples/chart/teleport-cluster/tests/auth_config_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,3 +502,11 @@ tests:
of: ConfigMap
- matchSnapshot:
path: data.teleport\.yaml

- it: sets "provisioned" billing mode when autoscaling is enabled
values:
- ../.lint/aws-dynamodb-autoscaling.yaml
asserts:
- matchRegex:
path: data.teleport\.yaml
pattern: 'billing_mode: provisioned'