Reduce memory leakage in API client caused by otelgrpc interceptors#30767
Merged
strideynet merged 3 commits intomasterfrom Aug 24, 2023
Merged
Reduce memory leakage in API client caused by otelgrpc interceptors#30767strideynet merged 3 commits intomasterfrom
otelgrpc interceptors#30767strideynet merged 3 commits intomasterfrom
Conversation
rosstimothy
approved these changes
Aug 21, 2023
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Thanks for the fix @strideynet 🙌 !
capnspacehook
approved these changes
Aug 21, 2023
public-teleport-github-review-bot
Bot
removed request for
camscale,
lxea,
ryanclark and
smallinsky
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@strideynet See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #30759
Closes #30759
There shouldn't be an issue with multiple clients sharing the "same" interceptor as we don't pass any custom options into the interceptor.