Allow Azure/IAM join over reverse tunnel#30720
Merged
Conversation
jakule
approved these changes
Aug 23, 2023
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| defer lib.SetInsecureDevMode(false) | |
| t.Cleanup(func() { lib.SetInsecureDevMode(false) }) |
Contributor
There was a problem hiding this comment.
Can you add a short comment on why we add them and how is using them for the new listeners?
lxea
approved these changes
Aug 24, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from hugoShaka
This change adds support for gRPC-based join methods (Azure and IAM) over the reverse tunnel port.
atburke
force-pushed
the
atburke/iam-join-reverse-tunnel
branch
from
12cc84a to
1b679a8
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for gRPC-based join methods (Azure and IAM) over the reverse tunnel port.
Resolves #25152.