Skip to content

Ensure the correct stderr is used for ssh sessions#30644

Merged
rosstimothy merged 1 commit intomasterfrom
tross/web_ui_stderr
Aug 18, 2023
Merged

Ensure the correct stderr is used for ssh sessions#30644
rosstimothy merged 1 commit intomasterfrom
tross/web_ui_stderr

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy commented Aug 17, 2023

Sessions were always copying the remote session standard error to os.Stderr instead of the TeleportClient.Stderr which prevented error messages from being seen in the web ui.

Fixes #30621

@rosstimothy
Copy link
Copy Markdown
Contributor Author

image

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from fspmarshall August 18, 2023 15:10
Sessions were always copying the remote session standard error to
os.Stderr instead of the `TeleportClient.Stderr` which prevented
error messages from being seen in the web ui.

Fixes #30621
@rosstimothy rosstimothy enabled auto-merge August 18, 2023 15:13
@rosstimothy rosstimothy added this pull request to the merge queue Aug 18, 2023
Merged via the queue into master with commit 6ce6624 Aug 18, 2023
@rosstimothy rosstimothy deleted the tross/web_ui_stderr branch August 18, 2023 15:44
@public-teleport-github-review-bot
Copy link
Copy Markdown

@rosstimothy See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Failed
branch/v13 Create PR

rosstimothy added a commit that referenced this pull request Aug 18, 2023
Sessions were always copying the remote session standard error to
os.Stderr instead of the `TeleportClient.Stderr` which prevented
error messages from being seen in the web ui.

Fixes #30621
rosstimothy added a commit that referenced this pull request Aug 18, 2023
Sessions were always copying the remote session standard error to
os.Stderr instead of the `TeleportClient.Stderr` which prevented
error messages from being seen in the web ui.

Fixes #30621
github-merge-queue Bot pushed a commit that referenced this pull request Aug 21, 2023
Sessions were always copying the remote session standard error to
os.Stderr instead of the `TeleportClient.Stderr` which prevented
error messages from being seen in the web ui.

Fixes #30621
github-merge-queue Bot pushed a commit that referenced this pull request Aug 21, 2023
Sessions were always copying the remote session standard error to
os.Stderr instead of the `TeleportClient.Stderr` which prevented
error messages from being seen in the web ui.

Fixes #30621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moderated sessions should gracefully fail in OSS

3 participants