Skip to content

[v12] Discover RDS: remove aurora engine #30547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoandredinis merged 1 commit into from
Aug 17, 2023
Merged

[v12] Discover RDS: remove aurora engine #30547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/packages/teleport/src/Discover/Database/EnrollRdsDatabase/EnrollRdsDatabase.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const fixtures: CheckedAwsRdsDatabase[] = [
},
{
name: 'alpaca',
engine: 'aurora',
engine: 'aurora-mysql',
uri: '',
labels: [
{ name: 'env', value: 'prod' },
Expand Down
10 changes: 5 additions & 5 deletions web/packages/teleport/src/services/integrations/integrations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ test('fetchAwsDatabases response', async () => {

describe('fetchAwsDatabases() request body formatting', () => {
test.each`
protocol | expectedEngines | expectedRdsType
${'mysql'} | ${['mysql', 'mariadb']} | ${'instance'}
${'postgres'} | ${['postgres']} | ${'instance'}
${'aurora-mysql'} | ${['aurora', 'aurora-mysql']} | ${'cluster'}
${'aurora-postgres'} | ${['aurora-postgresql']} | ${'cluster'}
protocol | expectedEngines | expectedRdsType
${'mysql'} | ${['mysql', 'mariadb']} | ${'instance'}
${'postgres'} | ${['postgres']} | ${'instance'}
${'aurora-mysql'} | ${['aurora-mysql']} | ${'cluster'}
${'aurora-postgres'} | ${['aurora-postgresql']} | ${'cluster'}
`(
'format protocol $protocol',
async ({ protocol, expectedEngines, expectedRdsType }) => {
Expand Down
2 changes: 1 addition & 1 deletion web/packages/teleport/src/services/integrations/integrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const integrationService = {
body = {
...req,
rdsType: 'cluster',
engines: ['aurora', 'aurora-mysql'],
engines: ['aurora-mysql'],
};
break;
case 'aurora-postgres':
Expand Down
1 change: 0 additions & 1 deletion web/packages/teleport/src/services/integrations/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ export type Regions = keyof typeof awsRegionMap;
// used when requesting lists of rds databases of the
// specified engine.
export type RdsEngine =
| 'aurora' // (for MySQL 5.6-compatible Aurora)
| 'aurora-mysql' // (for MySQL 5.7-compatible and MySQL 8.0-compatible Aurora)
| 'aurora-postgresql'
| 'mariadb'
Expand Down