Discover RDS: remove aurora engine#30544
Merged
marcoandredinis merged 1 commit intomasterfrom Aug 16, 2023
Merged
Conversation
'aurora' was an engine identifier for the first version of the Amazon Aurora offering. It reached end of life in 28th Februray 2023 https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL56.EOL.html We must remove it from the list of available engines, otherwise AWS will return an error "unrecognized engine: aurora". The backend has an equivalent PR that handles this error and queries the remaining engines instead.
marcoandredinis
force-pushed
the
marco/remove_aurora_engine_awsoidc_listdatabases
branch
from
c0f7885 to
aad7477
Compare
ryanclark
approved these changes
Aug 16, 2023
greedy52
approved these changes
Aug 16, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
kimlisa
marcoandredinis
deleted the
marco/remove_aurora_engine_awsoidc_listdatabases
branch
|
@marcoandredinis See the table below for backport results.
|
This was referenced Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'aurora' was an engine identifier for the first version of the Amazon Aurora offering.
It reached end of life in 28th Februray 2023
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL56.EOL.html
We must remove it from the list of available engines, otherwise AWS will return an error "unrecognized engine: aurora".
This ends up being an alternative PR to the following
#30269
Fixes: #29974