Fetch metadata in background for heartbeat#30528
Merged
Conversation
zmb3
reviewed
Aug 16, 2023
Collaborator
There was a problem hiding this comment.
Feels like we can simplify this. Did you consider using a sync.Once?
codingllama
reviewed
Aug 16, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Suggestion to have a bit less code.
Could we exercise this by calling NewSSHServerHeartbeat?
zmb3
reviewed
Aug 17, 2023
zmb3
reviewed
Aug 21, 2023
Contributor
Author
|
Friendly ping @zmb3 |
zmb3
approved these changes
Aug 23, 2023
codingllama
reviewed
Aug 23, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Looks good, mostly testing comments.
codingllama
approved these changes
Aug 24, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from EdwardDowling
This change updates SSH server heartbeats to fetch metadata in the background so that the first heartbeat won't be delayed (this was causing flakiness in tests).
atburke
force-pushed
the
atburke/heartbeat-test-flake
branch
from
fd4f6a9 to
d5d05f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates SSH server heartbeats to fetch metadata in the background so that the first heartbeat won't be delayed (this was causing flakiness in tests).