pam: free conversation buffer on error#30466
Merged
Merged
Conversation
As per pam_conv(3): > On failure, the conversation function should release any resources > it has allocated, and return one of the predefined PAM error codes. Fixes gravitational/teleport-private#661
rosstimothy
approved these changes
Aug 14, 2023
codingllama
approved these changes
Aug 15, 2023
public-teleport-github-review-bot
Bot
removed request for
camscale,
reedloden and
smallinsky
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per pam_conv(3):
Fixes gravitational/teleport-private#661