[v13] fix: Explicitly mention OTPs on tsh/Windows logins#30444
Merged
Conversation
rosstimothy
approved these changes
Aug 14, 2023
zmb3
approved these changes
Aug 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #30302 to branch/v13
Explicitly mention OTPs, when running
tsh loginon Windows, if the user hasboth OTP and WebAuthn registered.
"Platform" logins, like Windows WebAuthn, do not use the "normal" MFA prompts.
This makes sense, as the OS shows its own dialogs. In the case of Touch ID we
know the login will succeed, so it just takes over. For Windows, less so.
This customizes the Windows prompt when OTP and WebAuthn are possible. Note that
the Windows platform prompt is a modal and must be canceled before the OTP is
entered, that's why the message says "enter the code here".
Example:
#25051