Changes to Discord plugin for running in hosted mode.#30432
Merged
Conversation
Includes: * Moves Default API URL setting into Sidcord config CheckAndSetDefaults() * Only creates a Teleport client is one is not supplied during plugin construction. * Optional hosted-plugin status updates
hugoShaka
approved these changes
Aug 15, 2023
Comment on lines
+38
to
+46
|
|
||
| // Teleport is a handle to the client to use when communicating with | ||
| // the Teleport auth server. The PagerDuty app will create a GRPC- | ||
| // based client on startup if this is not set. | ||
| Client teleport.Client | ||
|
|
||
| // StatusSink receives any status updates from the plugin for | ||
| // further processing. Status updates will be ignored if not set. | ||
| StatusSink common.StatusSink |
Contributor
There was a problem hiding this comment.
If we are going to make all plugins runnable in managed mode, would it make sense to put those fields in the BaseConfig?
r0mant
approved these changes
Aug 17, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
CheckAndSetDefaults()
plugin construction.
Changelog: none