Skip to content

[v13] integrations/access: Make the plugins exit when the connection breaks instead of retrying infinetly and hanging#30431

Merged
hugoShaka merged 1 commit intobranch/v13from
hugo/backport-30039-to-branch/v13
Aug 14, 2023
Merged

[v13] integrations/access: Make the plugins exit when the connection breaks instead of retrying infinetly and hanging#30431
hugoShaka merged 1 commit intobranch/v13from
hugo/backport-30039-to-branch/v13

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

Backport #30039 to branch/v13

… instead of retrying infinetly and hanging (#30039)

* integrations/access: avoid infinite retry on broken connection

This commit changes the watcherjob retry behaviour. Instead of relying
on gRPC's retry mechanism, the plugins will now fail fast when something
happens to the connection. This means the plugin will exit in error more
often, but it won't be stuck in a retry loop, silently smallowing
connection errors.

* Add TELEPORT_PLUGIN_FAIL_FAST environment variable

* fixup! Add TELEPORT_PLUGIN_FAIL_FAST environment variable
@hugoShaka hugoShaka added teleport-plugin Tickets related to Teleport Plugins https://github.com/gravitational/teleport-plugins changelog labels Aug 14, 2023
@hugoShaka hugoShaka changed the title integrations/access: Make the plugins exit when the connection breaks instead of retrying infinetly and hanging [v13] integrations/access: Make the plugins exit when the connection breaks instead of retrying infinetly and hanging Aug 14, 2023
Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from fspmarshall August 14, 2023 15:13
@hugoShaka hugoShaka added this pull request to the merge queue Aug 14, 2023
Merged via the queue into branch/v13 with commit d3f496d Aug 14, 2023
@hugoShaka hugoShaka deleted the hugo/backport-30039-to-branch/v13 branch August 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport size/sm teleport-plugin Tickets related to Teleport Plugins https://github.com/gravitational/teleport-plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants