Metrics: expose install method counter#30327
Merged
marcoandredinis merged 2 commits intomasterfrom Aug 18, 2023
Merged
Conversation
marcoandredinis
force-pushed
the
marco/prometheus_install_method
branch
4 times, most recently
from
f3ea3ea to
1ab5495
Compare
marcoandredinis
added
discover
github-actions
Bot
requested review from
lsgunn-teleport,
mdwn,
ptgott,
r0mant,
ravicious,
xinding33 and
zmb3
ptgott
approved these changes
Aug 11, 2023
marcoandredinis
force-pushed
the
marco/prometheus_install_method
branch
2 times, most recently
from
69a12c4 to
f11b19d
Compare
mdwn
approved these changes
Aug 16, 2023
ravicious
approved these changes
Aug 18, 2023
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I have little experience with this part of the codebase, but the code looks good to me.
public-teleport-github-review-bot
Bot
removed request for
lsgunn-teleport,
r0mant,
xinding33 and
zmb3
marcoandredinis
force-pushed
the
marco/prometheus_install_method
branch
from
f11b19d to
5afb6b9
Compare
This PR adds a new metric that exposes the number of servers currently running grouped by their install method. Note: install method is a list o strings, so the metric sorts its values and then joins them by "," to create a single identifier.
marcoandredinis
force-pushed
the
marco/prometheus_install_method
branch
from
5afb6b9 to
18e8b08
Compare
|
@marcoandredinis See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new metric that exposes the number of servers currently running grouped by their install method.
Demo:
Note: install method is a list o strings, so the metric sorts its values and then joins them by "," to create a single identifier.
Related: #29988