[v13] Error if users attempt to do tsh login --headless#30307
Merged
codingllama merged 1 commit intobranch/v13from Aug 12, 2023
Merged
[v13] Error if users attempt to do tsh login --headless#30307codingllama merged 1 commit intobranch/v13from
tsh login --headless#30307codingllama merged 1 commit intobranch/v13from
Conversation
* Do not trigger SSO warning for local auth * Escalate headless debug log to error * Tweak error message Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
github-actions
Bot
added
backport
size/sm
tsh
Contributor
Author
|
I'm not sure exactly what the conflict was, I just took the PR lines without change. |
zmb3
approved these changes
Aug 10, 2023
Contributor
Author
|
Friendly ping @Joerger ? |
Joerger
approved these changes
Aug 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #30298 to branch/v13.
Instead of silently defaulting to local login, which can run into other errors
and potentially confuse the user (it did confuse us), we now error if the user
attempts to do
tsh login --headless.I've snuck in a fix for the "SSO login warning" logic, as it was showing for me
on a local cluster.
#28045