Conversation
greedy52
added
database-access
GavinFrazar
approved these changes
Aug 9, 2023
Tener
approved these changes
Aug 10, 2023
smallinsky
approved these changes
Aug 10, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
greedy52
deleted the
STeve/p471_fix_assume_role_arn_discovery_resource_checker
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #29864
This change makes sure DiscoveryResourceChecker receives the database copy with the updated AssumeRoleARN. UT updated.
Note that the resource matcher AssumeRoleARN feature is not documented yet so not expecting many using it. Also the DiscoveryResourceChecker (crednetialsChecker) only prints warnings. So the bug has no real functional impact.