[v12] Use distinct prompts during Windows WebAuthn registration#30216
Merged
codingllama merged 2 commits intobranch/v12from Aug 9, 2023
Merged
[v12] Use distinct prompts during Windows WebAuthn registration#30216codingllama merged 2 commits intobranch/v12from
codingllama merged 2 commits intobranch/v12from
Conversation
github-actions
Bot
added
backport
size/sm
tsh
rosstimothy
approved these changes
Aug 9, 2023
zmb3
approved these changes
Aug 9, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from tobiaszheller
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #30195 to branch/v12
Clearly distinguish between "registered" and "new" devices on Windows "platform"
prompts. This is relevant for Windows because it uses the system APIs for both
Hello and WebAuthn devices.
I've decided against doing a similar change for Touch ID, as there isn't much to
confuse there (lib/auth/touchid doesn't prompt devices other than Touch ID).
Changing the globals is safe because only one WebAuthn prompt happens at a time.
#17563
Changelog: Explicitly mention registered and new device when running
tsh mfa addon Windows