Add DeleteClusterMaintenanceConfig for terraform#30214
Merged
Merged
Conversation
greedy52
reviewed
Aug 9, 2023
greedy52
approved these changes
Aug 9, 2023
r0mant
reviewed
Aug 10, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@fspmarshall Can you review this please? Is it ok to let self-hosted users delete cloud maintenance config? This is needed to let terraform manage the resource.
fspmarshall
approved these changes
Aug 17, 2023
Contributor
|
Deleting cmc is totally fine, just needs to be disabled for Cloud, which this PR does. |
lxea
force-pushed
the
lxea/reset-cluster-maintenance-config
branch
from
303fdce to
2cb70f3
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terraform code gen in teleport-plugins expects a Delete method for resources
Part of #26066
Fixes #26185