Skip to content

Add PIV support for Kube Access with tsh proxy kube and Teleport Connect#30205

Merged
Joerger merged 1 commit intomasterfrom
joerger/add-piv-support-for-tsh-proxy-kube
Aug 14, 2023
Merged

Add PIV support for Kube Access with tsh proxy kube and Teleport Connect#30205
Joerger merged 1 commit intomasterfrom
joerger/add-piv-support-for-tsh-proxy-kube

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Aug 9, 2023

Use a plain RSA key for the local kube proxy to fix Hardware Key support for tsh proxy kube and Teleport Connect.

@Joerger Joerger marked this pull request as ready for review August 9, 2023 02:06
@github-actions github-actions Bot requested review from jakule and lxea August 9, 2023 02:06
@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Aug 9, 2023
@Joerger Joerger requested a review from greedy52 August 9, 2023 02:10
Comment thread tool/tsh/common/kube_proxy.go
@greedy52
Copy link
Copy Markdown
Contributor

greedy52 commented Aug 9, 2023

Could you also update it here:

// A key is required here for generating local CAs. It can be any key.
// Reading the provided key path to avoid generating a new one.
key, err := keys.LoadPrivateKey(k.cfg.KeyPath)
if err != nil {
return nil, trace.Wrap(err)
}

Thanks!

@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented Aug 11, 2023

@greedy52 Nice catch, thanks!

@Joerger Joerger changed the title Add PIV support for tsh proxy kube Add PIV support for Kube Access with tsh proxy kube and Teleport Connect Aug 11, 2023
Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joerger Will it work in Connect too?

@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented Aug 11, 2023

@Joerger Will it work in Connect too?

Yes

@Joerger Joerger enabled auto-merge August 11, 2023 20:32
@Joerger Joerger force-pushed the joerger/add-piv-support-for-tsh-proxy-kube branch from e453308 to 817b5aa Compare August 11, 2023 20:34
@Joerger Joerger added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 11, 2023
@Joerger Joerger added this pull request to the merge queue Aug 14, 2023
Merged via the queue into master with commit 963ee50 Aug 14, 2023
@Joerger Joerger deleted the joerger/add-piv-support-for-tsh-proxy-kube branch August 14, 2023 20:07
@public-teleport-github-review-bot
Copy link
Copy Markdown

@Joerger See the table below for backport results.

Branch Result
branch/v13 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kubernetes-access size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants