Ensure http.Server has idle and read timeouts configured#30151
Merged
Ensure http.Server has idle and read timeouts configured#30151
Conversation
Configures the `ReadHeaderTimeout` and `IdleTimeout` for instances of `http.Server` highlighted by `gosec`.
jentfoo
requested review from
codingllama,
jakule,
r0mant,
rosstimothy,
strideynet and
zmb3
rosstimothy
approved these changes
Aug 7, 2023
| "google.golang.org/grpc/credentials/insecure" | ||
| "google.golang.org/protobuf/proto" | ||
|
|
||
| apidefaults "github.com/gravitational/teleport/api/defaults" |
Contributor
There was a problem hiding this comment.
nit: there's only a single defaults package imported here so we can drop the alias
Suggested change
| apidefaults "github.com/gravitational/teleport/api/defaults" | |
| "github.com/gravitational/teleport/api/defaults" |
Contributor
Author
There was a problem hiding this comment.
Current imports of this defaults all seemed to be consistently aliasing to apidefaults. So I was just trying to stay consistent to that existing usage. Let me know your thoughts
Contributor
There was a problem hiding this comment.
That's likely only the case when "github.com/gravitational/teleport/lib/defaults" is also imported
Contributor
There was a problem hiding this comment.
IMO having the same aliases across all files makes things simpler. Otherwise, if lib/defaults is added to these files, we may end up with libdefaults and defaults, which points to something completely different than you would expect.
jakule
approved these changes
Aug 8, 2023
strideynet
approved these changes
Aug 8, 2023
public-teleport-github-review-bot
Bot
removed request for
codingllama,
jimbishopp,
r0mant and
zmb3
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
jentfoo
added a commit
that referenced
this pull request
Aug 10, 2023
This commit builds on the work from #30151 in the following ways: * A couple additional server configuartions that were missing timeouts are now covered * Timeouts are now configured in a consistent way. This means: - Configuring the `ReadTimeout` which was not covered by only setting `ReadHeaderTimeout` - Set `ReadHeaderTimeout` to be the more aggressive (1 second) `defaults.ReadHeadersTimeout` - Set a `WriteTimeout` in cases of potential large responses
jentfoo
added a commit
that referenced
this pull request
Aug 11, 2023
This commit builds on the work from #30151 in the following ways: * A couple additional server configuartions that were missing timeouts are now covered * Timeouts are now configured in a consistent way. This means: - Configuring the `ReadTimeout` which was not covered by only setting `ReadHeaderTimeout` - Set `ReadHeaderTimeout` to be the more aggressive (1 second) `defaults.ReadHeadersTimeout` - Set a `WriteTimeout` in cases of potential large responses
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
* Consistent `http.Server` timeout configurations This commit builds on the work from #30151 in the following ways: * A couple additional server configuartions that were missing timeouts are now covered * Timeouts are now configured in a consistent way. This means: - Configuring the `ReadTimeout` which was not covered by only setting `ReadHeaderTimeout` - Set `ReadHeaderTimeout` to be the more aggressive (1 second) `defaults.ReadHeadersTimeout` - Set a `WriteTimeout` in cases of potential large responses * defaults.go: Update ReadHeadersTimeout to 10 seconds * alpnproxy/local_proxy.go: Move http timeouts to the top
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configures the
ReadHeaderTimeoutandIdleTimeoutfor instances ofhttp.Serverhighlighted bygosec. Similar to the PR here: https://github.com/gravitational/teleport.e/pull/1948