[v13] WebDiscover: Enable auto deploy and skip IAM policy screen on condition#29978
Merged
kimlisa merged 2 commits intobranch/v13from Aug 3, 2023
Merged
[v13] WebDiscover: Enable auto deploy and skip IAM policy screen on condition#29978kimlisa merged 2 commits intobranch/v13from
kimlisa merged 2 commits intobranch/v13from
Conversation
* Define the return type * Add endpoint for config script * Store the entire integration object instead of just the name * Build the correct script string, renames, emit event * Enable auto deploy as default * Fix script endpoint and update story * Add regex check, update story * Touch ups, add test * Address CR * Remove sudo from bash command * Make into ui friendly object
* Prevent going back from access screen if deploying got skipped * Configuring perms for the user can take some time An error can return if a user tried to deploy before the changes are fully propagated. Notify the user that this can be a reason why an error returned and try again. * Check if IAM policy already configured with new dbs Clarify poller callback with comment Make IAMPolicy screen optional
github-actions
Bot
requested review from
ibeckermayer,
marcoandredinis and
ryanclark
ryanclark
approved these changes
Aug 3, 2023
r0mant
approved these changes
Aug 3, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
marcoandredinis
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports #28621 and #29724 to branch/v13
clean backports, just had to do manual because it depended on another backport that didn't get in before auto backport ran
Changelog: Added support for the web UI for automatically deploying a database service with ECS Fargate container when enrolling a new database