[Mattermost] Lax requiring recipients and set raw recipients on cfg init #29889
Merged
[Mattermost] Lax requiring recipients and set raw recipients on cfg init #29889
Conversation
2 tasks
flyinghermit
approved these changes
Aug 2, 2023
tigrato
approved these changes
Aug 3, 2023
r0mant
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the standalone mattermost plugin from: gravitational/teleport-plugins#876, ran into an error where raw recipients (from config) were not getting notified b/c the raw recipients were not being set on config init which this PR fixes and tests.
I also defined toml fields. It wasn't necessary but figured it wouldn't hurt to if the go struct field name changes for whatever reason
Also laxes requiring
team/channel, this was the original implementation (something I failed to understand when refactoring). It's okay for these fields to be left blank, because the mattermost plugin also sends notifications to thesuggested reviewersdefined in the access request (as long as it can be matched with mattermost users email).If there are no team/channel, email, or suggested reviewers defined then the plugin logs this:
if there is a suggested reviewer that doesn't exist in mattermost, the plugin logs this: