Skip to content

Added Prometheus metric for created access requests#29761

Merged
r0mant merged 1 commit intomasterfrom
roman/reqmetrics
Jul 29, 2023
Merged

Added Prometheus metric for created access requests#29761
r0mant merged 1 commit intomasterfrom
roman/reqmetrics

Conversation

@r0mant
Copy link
Copy Markdown
Collaborator

@r0mant r0mant commented Jul 28, 2023

This is needed for some product analytics. Tested this locally, example reported metrics after submitting a few access requests:

➜  ~ curl -s http://root.gravitational.io:3000/metrics | grep access_requests_created
# HELP teleport_access_requests_created Tracks the number of created access requests
# TYPE teleport_access_requests_created counter
teleport_access_requests_created{resources="0",roles="1"} 1
teleport_access_requests_created{resources="1",roles="1"} 1
teleport_access_requests_created{resources="3",roles="1"} 1

@github-actions github-actions Bot requested review from kimlisa and zmb3 July 28, 2023 23:12
@r0mant r0mant enabled auto-merge July 29, 2023 00:27
@r0mant r0mant added this pull request to the merge queue Jul 29, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 29, 2023
@r0mant r0mant added this pull request to the merge queue Jul 29, 2023
Merged via the queue into master with commit 3c0f7fc Jul 29, 2023
@r0mant r0mant deleted the roman/reqmetrics branch July 29, 2023 15:25
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Jul 29, 2023

@r0mant See the table below for backport results.

Branch Result
branch/v13 Failed

r0mant added a commit that referenced this pull request Aug 3, 2023
@r0mant
Added Prometheus metric for created access requests (#29761)
410d29e
@r0mant r0mant mentioned this pull request Aug 3, 2023
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Aug 3, 2023
@r0mant
Added Prometheus metric for created access requests (#29761) (#29991)
53155e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russjones russjones russjones approved these changes

@kimlisa kimlisa Awaiting requested review from kimlisa

@zmb3 zmb3 Awaiting requested review from zmb3

+1 more reviewer

@jakule jakule jakule approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r0mant @russjones @jakule