Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON for trait encoding. #2970

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Use JSON for trait encoding. #2970

merged 2 commits into from
Sep 11, 2019

Conversation

russjones
Copy link
Contributor

Description

Use JSON for trait encoding. Fallback to protobuf.

fspmarshall
fspmarshall approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@fspmarshall fspmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be nice to have a DELETE IN 4.X directive for the protobuf compat (though I'm not sure when that would be in this case 😕).

@russjones russjones merged commit f0a455f into master Sep 11, 2019
@russjones russjones deleted the rjones/fix-traits branch September 11, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fspmarshall fspmarshall fspmarshall approved these changes

@klizhentas klizhentas klizhentas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russjones @klizhentas @fspmarshall