Add option to remove traits or roles from the app JWT header #29687
Merged
Add option to remove traits or roles from the app JWT header #29687
Conversation
zmb3
reviewed
Jul 27, 2023
zmb3
approved these changes
Jul 27, 2023
Contributor
Author
|
@mdwn friendly ping :) |
r0mant
reviewed
Aug 2, 2023
r0mant
approved these changes
Aug 4, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
Please test backwards compatibility but otherwise lgtm.
stringify & remove the jwt values when asked Plumb up the file configuration Add a test for jwt token rewriting resolve comments Use string instead of enum
Collaborator
|
@lxea Can you please send a follow up PR to document this? |
Contributor
|
Will this be backported to any release branches? |
Collaborator
|
@programmerq Yes, we will backport to all active release branches. |
This was referenced Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23924
Implemented as suggested here #23924 (comment)