Update discovery installers to work with zypper#29360
Conversation
r0mant
left a comment
There was a problem hiding this comment.
Can you update auto-upgrades and Discover install scripts as well?
The discovery scripts are the ones updated here, are there other ones? The auto-upgrades script is in e so i'll do that in a separate PR |
There was a problem hiding this comment.
Is there a reason we're using $OSTYPE rather than checking against uname ? It seems more portable and works on macos too.
opensuse defines OSTYPE as linux, ubuntu defines it as linux-gnu and alpine (for example) doesn't define it, where as uname is just Linux on all of them
There was a problem hiding this comment.
👍 I'm happy with this as is - especially since thats currently how it is - but it'd be nice to see us use uname instead.
71361c6 to
160bfed
Compare
|
@lxea By Discover I meant the node-join script that users download via Teleport Discover interface (when you click on add a server resource for example): https://github.com/gravitational/teleport/blob/master/lib/web/scripts/node-join/install.sh. |
ibeckermayer
left a comment
There was a problem hiding this comment.
LGTM in terms of bash script fundamentals, the details are beyond my understanding
|
@lxea Let's hold this off until @fheinecke adds the SUSE channel so we can remove RHEL version hardcodes from the scripts. |
|
@fheinecke IIRC you set up the zypper repository and was going to configure a separate DNS name for it. Is it done now, can we update this PR? |
ab19082 to
ea53313
Compare
manually import the gpg key if we're on sles 12 Update the node-join installer untabify
ea53313 to
fa78e95
Compare
Yeah, all of these appear to be working, tried on a fresh AWS SLES instance |
There was a problem hiding this comment.
👍 I'm happy with this as is - especially since thats currently how it is - but it'd be nice to see us use uname instead.
This updates the automatic server discovery scripts to work with zypper
As it stands it hard-codes that its using the RHEL v8 teleport RPM repo, though I'm not sure if this is the best idea, and if we should instead host suse specific RPMs
Part of #29267